GDScript: Allow trying to reload shallow script when instantiated #97302
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #95789
this allows automatically compiling scripts on demand when calling
script.new()
in a very limited way to avoid errors from the wrong order of compiling dependencies that would otherwise be more difficult to solvei looked back at the solution i mentioned in #95789 (comment)
and i think the solution i mentioned is actually fine, the gdscript compiler is not designed for multithreading, so, without accounting for that the logic is simple:
when a script is created it has a
bool shallow
set totrue
while reloading,
reloading
is set totrue
like usualat the beginning of compilation,
shallow
is set tofalse
then when instantiating a not-valid shallow root script that is not currently reloading, tries to reload it
also adds a better error message and call error