Add Unit Test cases for Sky
#97512
Merged
Add Unit Test cases for Sky
#97512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Sep 28, 2024
akien-mga
force-pushed
the
mestopinal-sky-tests
branch
from
e7dfc5e to
136e4d5
Compare
|
I pushed a rebase to squash the commits together as per our preferred PR workflow, so this should be ready to merge. |
Calinou
approved these changes
Oct 1, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43440.
Adds several test cases for the
Skyclass.Essentially just tests adds test coverage for the constructors default values and the setter and getter (and error behavior for
set_radiance_size)