Add activate_feed and deactivate_feed virtual bind to CameraFeed
#97571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j20001970
force-pushed
the
camerafeed-virtual
branch
4 times, most recently
from
b23e1d1 to
9fd373d
Compare
j20001970
force-pushed
the
camerafeed-virtual
branch
from
9fd373d to
3720de4
Compare
m4gr3d
approved these changes
Dec 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #97534
In order to implement custom CameraFeed in GDExtension,
activate_feedanddeactivate_feedneed to be override-able by its subclasses, so that their behaviour can be reached whenset_activeis called.This PR adds virtual bind for these two methods, such that they are exposed to GDExtension binding.