Add new test cases for Timer autostart and paused behavior
#97794
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadiantUwU
approved these changes
Oct 4, 2024
AThousandShips
changed the title
Timer autostart and paused behavior
|
It did not, in fact, pass. Most of the errors are about replacing the spaces with tabulation. |
Mickeon
reviewed
Oct 4, 2024
| @@ -212,6 +212,46 @@ TEST_CASE("[SceneTree][Timer] Check Timer timeout signal") { | |||
| memdelete(test_timer); | |||
| } | |||
|
|
|||
| // Test case for timer autostart feature. | |||
| // Ensures that when autostart is enabled, the timer starts automatically when added to scene. | |||
| TEST_CASE("[SceneTree][Timer] Autostart behavior") { | |||
There was a problem hiding this comment.
I sent the review too early but
Suggested change
| TEST_CASE("[SceneTree][Timer] Autostart behavior") { | |
| TEST_CASE("[SceneTree][Timer] Check Timer Autostart behavior") { |
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new unit tests for the
Timerclass to help improve test coverage as part of issue #43440. The tests cover the following scenarios:autostartproperty is enabled, the timer starts automatically when added to the scene.Link to pull request issue: #43440
Thanks!