Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for reflection_probe #97870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sticksman
Copy link
Contributor

Added reflection_probe_test under scenes/test. Part of issue #43440

@Sticksman Sticksman requested a review from a team as a code owner October 6, 2024 06:00
@Sticksman Sticksman force-pushed the add-reflection-probe-test branch 2 times, most recently from aeba534 to 83379ca Compare October 6, 2024 08:18
@Sticksman Sticksman changed the title Add reflection probe test Add unit test for reflection_probe Oct 6, 2024
@dustdfg
Copy link
Contributor

dustdfg commented Oct 6, 2024

related to #97818

@Sticksman
Copy link
Contributor Author

I can work on different tests or merge this PR into the other if you'd prefer

@Chaosus Chaosus added this to the 4.4 milestone Oct 6, 2024
Split out default into separate test case
@Sticksman Sticksman force-pushed the add-reflection-probe-test branch from 83379ca to 4429158 Compare October 6, 2024 18:56
@Sticksman
Copy link
Contributor Author

Moved the reflection probe under the 3d_disabled guard to help with compilation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants