Fix decompressing textures with dimensions that are not multiples of 4 #97873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCube3310
force-pushed
the
image-decompress-4-fix
branch
from
ac9fb8a to
a60195e
Compare
|
@lyuma could you review this since you debugged an earlier problem like this |
clayjohn
approved these changes
Oct 6, 2024
|
Here are the original glbs that the texture was from if anyone wants to figure out how the images were imported like that: https://github.com/user-attachments/files/17269720/SmallShips.zip |
|
Thanks! |
|
Could it fix #85747 too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97862
Fixes the alignment of some compressed textures when decompressing. This issue seems to stem from the fact that the extra padding on compressed images is not taken into account when importing as VRAM compressed.
Also, the image linked in the issue's MRP seems to not decompress properly. Looking into the image's data, it looks like the endpoint indices are unusual (set to 1, for solid color blocks most compressors set them to 0). This tricks bcdec into thinking that the block has punchthrough transparency and incorrectly decompresses it. Godot doesn't support the BC1 punchthrough mode, so the compressed images appear fine.