Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when creating thumbnails for 3d textures #97979

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

BlueCube3310
Copy link
Contributor

Fixes #97879

Ensures that the depth is equal to the amount of slices.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. But I wonder why this situation was happening in the OP? Is the editor somehow trying to preview the noise texture before it is created?

@BlueCube3310
Copy link
Contributor Author

Seems fine. But I wonder why this situation was happening in the OP? Is the editor somehow trying to preview the noise texture before it is created?

I think before actual noise data is provided, the editor creates a dummy texture with uninitialized data that doesn't match up with its properties

@clayjohn
Copy link
Member

clayjohn commented Oct 8, 2024

That makes sense. Thank you.

I think you need to rebase on master to pass CI. There were some changes to the MacOS CI earlier today

@Repiteo Repiteo merged commit 92e51fc into godotengine:master Oct 10, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 10, 2024

Thanks!

@BlueCube3310 BlueCube3310 deleted the fix-thumb-gen branch October 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoiseTexture3D Index out of bounds crash. Forward+
5 participants