Image: More cleanup and reduced code duplication #98100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCube3310
force-pushed
the
image-cleanup-more
branch
from
6bef69f to
7789c4e
Compare
BlueCube3310
force-pushed
the
image-cleanup-more
branch
from
7789c4e to
67bb7d0
Compare
Calinou
reviewed
Dec 3, 2024
Calinou
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Code looks good to me.
This refactor will be helpful if we decide to implement more mipmap generation filters in the future 🙂
BlueCube3310
force-pushed
the
image-cleanup-more
branch
2 times, most recently
from
9dfe0a3 to
2848d75
Compare
BlueCube3310
force-pushed
the
image-cleanup-more
branch
from
2848d75 to
335077a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #98084
This PR reduces code duplication in the Image class (mostly for mipmap generation), and optimizes detecting color channels.