GDScript: Fix cached parser error when using typed Dictionaries #98400
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm this fixes the issue for me! |
dalexeev
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Looks good to me. I haven't tested this, but it seems reasonable. Also @rune-scape is the original author of the code and @tracefree confirmed that this fixes the issue.
rune-scape
force-pushed
the
fix-typed-dict-cached-parser
branch
from
5d1c37a to
eb8b989
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #96881
a small mistake from #94871 where i only checked the first of the container types
also added a message to
ensure_cached_external_parser_for_classexplaining its function