Fix exported typed dictionaries in .NET not being loaded correctly when their default value is null #98546
+90
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjp600
changed the title
juanjp600
force-pushed
the
dotnet-typed-dictionaries-default-null-export-fix
branch
from
f8b5698 to
2d287a1
Compare
…en their default value is null
juanjp600
force-pushed
the
dotnet-typed-dictionaries-default-null-export-fix
branch
from
2d287a1 to
48d56f6
Compare
raulsntos
reviewed
Jan 21, 2025
| } | ||
| r_key_subtype = Variant::Type(key_subtype_string.to_int()); | ||
| if (r_key_class_name != nullptr) { | ||
| *r_key_class_name = p_hint_string.substr(key_subtype_separator + 1, key_value_separator - (key_subtype_separator + 1)); |
There was a problem hiding this comment.
This doesn't work for Dictionary<MyEnum, Node> (see #101801). It will take the enum hint_string Value1,Value2,Value3 as the class_name which results in the following error when calling Dictionary::set_typed:
ERROR: Class names can only be set for type OBJECT.
I don't think you can assume that the hint_string will always be the class_name. I think that only works when the PropertyHint is PROPERTY_HINT_NODE_TYPE or PROPERTY_HINT_RESOURCE_TYPE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with #98545, this should fix #97850.
This is not entirely correct if the type arguments for the dictionary are script types. However, the hint string does not include any information about scripts, so I'm not sure what the best way to address it is.