Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Handle bundles as files in the embedded file dialogs. #98812

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[macOS] Handle bundles as files in the embedded file dialogs. #98812

merged 1 commit into from
Dec 3, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 4, 2024

  • Adds DirAccess function to detect bundles.
  • Allows selecting and filtering macOS bundles as a file (in both editor and generic file dialog). Bundle contents can be browsed by selecting "Show Package Contents" in the context menu (the same way it is working in Finder).

@bruvzg bruvzg added this to the 4.x milestone Nov 4, 2024
@bruvzg bruvzg marked this pull request as ready for review November 5, 2024 08:32
@bruvzg bruvzg requested review from a team as code owners November 5, 2024 08:32
akien-mga
akien-mga approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Needs rebase.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Dec 2, 2024
@bruvzg bruvzg force-pushed the macos_bundles_as_file branch from fdecae4 to 6f9e10c Compare December 2, 2024 15:47
AThousandShips
AThousandShips approved these changes Dec 3, 2024
View reviewed changes
doc/classes/DirAccess.xml Outdated Show resolved Hide resolved
editor/gui/editor_file_dialog.cpp Outdated Show resolved Hide resolved
@bruvzg bruvzg force-pushed the macos_bundles_as_file branch from 6f9e10c to d5e599f Compare December 3, 2024 10:42
@Repiteo Repiteo merged commit 44cda51 into godotengine:master Dec 3, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos topic:porting
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@bruvzg @Repiteo @akien-mga @AThousandShips