Remove pre-Visual Studio 2017 detection code in the buildsystem #98842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 5, 2024
akien-mga
approved these changes
Nov 5, 2024
Visual Studio 2017 or later has been required to build Godot for a while now.
Calinou
force-pushed
the
scons-vs-detect-remove-pre-2017
branch
from
e5dbda6 to
180f079
Compare
adamscott
approved these changes
Nov 5, 2024
|
Thanks! |
dustdfg
added a commit
to dustdfg/godot
that referenced
this pull request
Nov 19, 2024
Follow up to: godotengine#99217 and godotengine#98842 Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]>
dustdfg
added a commit
to dustdfg/godot
that referenced
this pull request
Nov 19, 2024
Follow up to: godotengine#99217 and godotengine#98842 Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]>
dustdfg
added a commit
to dustdfg/godot
that referenced
this pull request
Nov 19, 2024
Follow up to: godotengine#99217 and godotengine#98842 Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]> Co-authored-by: Thaddeus Crews <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2017 or later has been required to build Godot for a while now.