Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C# boolean "Prints" comments in documentation #99089

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Nov 11, 2024

See also #95762

In GDScript, print() prints "true" and "false".
In C#, GD.Print() prints "True" and "False".
So a lot of these comments in the class reference examples are technically inaccurate.

Note that, in the grand scheme of things, this is an extremely minor change. Approve and merge this PR only if you feel like this is worth the localization needing to be refreshed.

@Mickeon Mickeon added this to the 4.x milestone Nov 11, 2024
@Mickeon Mickeon requested a review from a team November 11, 2024 20:35
@Mickeon Mickeon requested a review from a team as a code owner November 11, 2024 20:35
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested all the examples, but the changes match how booleans are converted to string in C#.

@Mickeon Mickeon modified the milestones: 4.x, 4.4 Nov 13, 2024
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic as hell. I respect it.

@Repiteo Repiteo merged commit 4146bcc into godotengine:master Dec 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 11, 2024

Thanks!

@Mickeon Mickeon deleted the documentation-truth-csharp-rabbit-hoole branch December 14, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants