Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate read/write-only property warning from ScriptPropertiesGenerator #99206

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Remove duplicate read/write-only property warning from ScriptPropertiesGenerator #99206

merged 1 commit into from
Nov 18, 2024

Conversation

a-johnston
Copy link
Contributor

Small change that fixes #99205. This was just left behind from a previous change and while the double errors themselves are pretty innocuous I think it's valuable to clarify the comments.

@a-johnston a-johnston requested a review from a team as a code owner November 13, 2024 22:27
@a-johnston a-johnston mentioned this pull request Nov 14, 2024
Merged
@Chaosus Chaosus added this to the 4.4 milestone Nov 14, 2024
raulsntos
raulsntos approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested and works as expected. Thanks!

Since the bug was introduced in 4.2 (#67304), I'm adding the cherry-pick label for 4.2 and 4.3.

@raulsntos raulsntos added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 14, 2024
@Repiteo Repiteo merged commit 1889d2a into godotengine:master Nov 18, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 18, 2024

Thanks!

@a-johnston a-johnston deleted the fix_double_diagnostic branch November 18, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:dotnet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

C# diagnostics GD0103 and GD0104 are reported twice for properties
4 participants
@a-johnston @Repiteo @raulsntos @Chaosus