SCons: Address minor show_progress issues
#99292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
force-pushed
the
scons/show_progress-tweaks
branch
from
be189f3 to
dbbb05b
Compare
Repiteo
force-pushed
the
scons/show_progress-tweaks
branch
from
dbbb05b to
6d91d96
Compare
|
LGTM |
|
Is it about a fact that |
That being removed was deliberate, but this PR makes sure that it will only happen on an initial build |
akien-mga
approved these changes
Dec 16, 2024
|
Needs rebase. |
Repiteo
force-pushed
the
scons/show_progress-tweaks
branch
from
6d91d96 to
df6ac39
Compare
AThousandShips
approved these changes
Dec 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized a minor regression introduced by the above PR causing node count to not be tracked whatsoever if not displaying a progress bar. Additionally,
progress_finishas an SCons action is unnecessary & doesn't catch all cases; it's now handled viaatexitlike the cache cleaning