Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Set default ACCESS_FILESYSTEM root for FileDialog #99310

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

syntaxerror247
Copy link
Member

Before this PR:
The FileDialog defaults to the root folder ("/") on Android, requiring users to manually set the desired root folder.

After this PR:
When the access mode is set to Filesystem, FileDialog will automatically set its root to primary external storage.

scene/gui/file_dialog.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Dec 2, 2024
@Repiteo Repiteo merged commit 6472e9e into godotengine:master Dec 3, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2024

Thanks!

@syntaxerror247 syntaxerror247 deleted the filedialog_issue branch December 4, 2024 00:52
@akien-mga akien-mga changed the title Android: Set default ACCESS_FILESYSTEM root Android: Set default ACCESS_FILESYSTEM root Dec 5, 2024
@akien-mga akien-mga changed the title Android: Set default ACCESS_FILESYSTEM root Android: Set default ACCESS_FILESYSTEM root for FileDialog Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants