Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DisplayServer.beep. #99371

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Implement DisplayServer.beep. #99371

merged 1 commit into from
Dec 3, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 17, 2024

Implements DisplayServer.beep method to make annoying sounds.

Implements godotengine/godot-proposals#11179

@bruvzg bruvzg added this to the 4.x milestone Nov 17, 2024
@bruvzg bruvzg requested review from a team as code owners November 17, 2024 21:38
Riteo
Riteo approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wayland implementation checks out!

Calinou
Calinou approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Windows 11 23H2, it works as expected.

@mhilbrunner
Copy link
Member

Why DisplayServer.beep() and not OS.beep()?

@bruvzg
Copy link
Member Author

bruvzg commented Nov 18, 2024

Why DisplayServer.beep() and not OS.beep()?

It depends on X11 and Wayland to work.

mhilbrunner
mhilbrunner approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly tragic that you didn't expose the parameter to use the exclamation sound on Windows :p

Docs, style, code and Git commit LGTM. Haven't built and tested as Calinou was faster.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Dec 2, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Dec 2, 2024

I think it's really funny that we're bound to merge the ability for Godot developers to annoy the user with little demand

AThousandShips
AThousandShips approved these changes Dec 3, 2024
View reviewed changes
doc/classes/DisplayServer.xml Outdated Show resolved Hide resolved
@Repiteo Repiteo merged commit 40a65e7 into godotengine:master Dec 3, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2024

Thanks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon left review comments

@akien-mga akien-mga akien-mga left review comments

@AThousandShips AThousandShips AThousandShips approved these changes

@Riteo Riteo Riteo approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement feature proposal platform:linuxbsd platform:macos platform:windows topic:porting
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
8 participants
@bruvzg @mhilbrunner @Mickeon @Repiteo @Calinou @akien-mga @Riteo @AThousandShips