Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file dialog all files filter name from All Files (*) to All Files (*.*). #99644

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 24, 2024

Alternative to #99599, see #99599 (comment)

Should fix #99596

Note: only changes displayed name, Linux native dialogs still use * as actual filter to allow selecting files without extension.

@bruvzg bruvzg added this to the 4.4 milestone Nov 24, 2024
@bruvzg bruvzg requested review from a team as code owners November 24, 2024 18:11
@RedMser
Copy link
Contributor

RedMser commented Nov 24, 2024

I can confirm that it fixes the linked issue for me 👍

image
image

It's also more consistent with what other Windows 10 apps (e.g. Notepad) show, so to me it looks like an overall improvement.

Linux native dialogs still use * as actual filter to allow selecting files without extension.

For reviewers: On Windows, you can select files without extension even if the filter is *.*, so there is no functional changes here.

@AThousandShips AThousandShips changed the title Change file dialog all files filter name from All Files (*) to All Files(*.*). Change file dialog all files filter name from All Files (*) to All Files (*.*). Nov 25, 2024
@akien-mga akien-mga merged commit 60e1490 into godotengine:master Dec 2, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native FileDialog shows All Files (*) (*.*) filter on Windows 10
3 participants