Add unit tests for Sky #99886
Merged
Add unit tests for Sky #99886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Dec 3, 2024
Calinou
reviewed
Dec 3, 2024
ZhiyiHu93
force-pushed
the
update-sky-tests
branch
from
381d5d5 to
bf2d216
Compare
|
Changed all |
ZhiyiHu93
force-pushed
the
update-sky-tests
branch
from
bf2d216 to
d87645f
Compare
AThousandShips
approved these changes
Dec 6, 2024
ZhiyiHu93
force-pushed
the
update-sky-tests
branch
from
d87645f to
1e62c7f
Compare
|
Thanks! Congratulations on your first merged contribution! 🎉 |
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests to class Sky
This PR is part of #43440
Using gcov, the updated test_sky.h seems to have 100% line coverage for sky.cpp. However, I'm not sure if I still missed something, so any advice is welcome.