Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCPServer "Should disconnect client" test #99960

Conversation

pafuent
Copy link
Contributor

@pafuent pafuent commented Dec 3, 2024

"Should disconnect client" test was failing randomly on Mac CI tests, so this PR is making it more reliable reading on the closed client instead of writing to it.

I run it several times in a loop after fix it to test is not flaky anymore.

for i in `seq 100`; ./bin/godot.macos.editor.dev.x86_64 --test --test-case='[TCPServer] Should disconnect client*'

"Should disconnect client" test was failing randomly on Mac CI tests, so
this PR is making it more reliable reading on the closed client instead of
writing to it
@pafuent pafuent requested a review from a team as a code owner December 3, 2024 12:47
@AThousandShips AThousandShips added this to the 4.4 milestone Dec 3, 2024
@akien-mga akien-mga requested a review from a team December 3, 2024 12:54
@adamscott adamscott changed the title Fix TCPServer "Should disconnect client" test Fix TCPServer "Should disconnect client" test Dec 3, 2024
Copy link
Contributor

@demolke demolke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really get merged - the flakiness this is fixing keeps happening to unrelated PRs.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From discussing with networking maintainers they're not convinced that this makes the test really reliable / correct testing of TCP.

But let's give it a try as a stopgap solution, and if that doesn't solve the flakiness, we can disable that test.

@akien-mga akien-mga merged commit aa8d9b8 into godotengine:master Dec 6, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@pafuent pafuent deleted the fixing_tcp_server_flappy_disconnect_test branch December 6, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants