Wayland: Add support for xdg-foreign-unstable-v2 #99965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops. Meant @bruvzg |
Riteo
force-pushed
the
unstable-galore
branch
from
5b3e604 to
9f4086e
Compare
The v1 version is deprecated and bound to be removed in the future from all compositors. This patch adds a v1/v2 designator to everything related to the protocol and prefers the v2 protocol if both are available. Additionally, renames the event handler to follow the Wayland interface name, for consistency with the rest of the codebase.
Riteo
force-pushed
the
unstable-galore
branch
from
9f4086e to
65c28ed
Compare
|
Rebased. I also removed the bump of wayland-protocols as it was unncessary and updated the PR description accordingly. |
bruvzg
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Looks fine.
For the reference, it's only used for FileChooser portal window IDs - https://flatpak.github.io/xdg-desktop-portal/docs/window-identifiers.html
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v1 version is deprecated and bound to be removed in the future from all compositors. This patch adds a v1/v2 designator to everything related to the protocol and prefers the v2 protocol if both are available.
Additionally, renames the event handler to follow the Wayland interface name, for consistency with the rest of the codebase.
Should I wrap the deprecated protocols into the deprecated header? I don't think but it's worth pointing that out.
Also note that I added a lot of "deprecated" comments, no idea if that's excessive; feedback is welcome.
I tested the thing and it seems to work, although I'm not really sure how to check it properly.
dbus-monitorlooks fine and we indeed get a handle so I'm quite sure it works.cc @bruvgz as they implemented the protocol originally.