Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

fix(indexer): support compatible_chain_id for calculating eth_tx_hash #199

Merged
merged 3 commits into from
Mar 9, 2022
Merged

fix(indexer): support compatible_chain_id for calculating eth_tx_hash #199

merged 3 commits into from
Mar 9, 2022

Conversation

RetricSu
Copy link
Contributor

@RetricSu RetricSu commented Mar 8, 2022 •
edited
Loading

in this pr:

  • fix the web3-indexer calculating eth_tx_hash bug by enable compatible_chain_id
  • update env config in web3 api-server:
    • remove the chain_Id env
    • add compatible_chain_id instead
    • and calculating chain_id with creator_id and compatible_chain_id

@RetricSu RetricSu requested a review from classicalliu March 8, 2022 10:33
@Flouse Flouse linked an issue Mar 8, 2022 that may be closed by this pull request
v1: Check the Hashes of transactions from eth_getBlockByHash RPC #198
Closed
@Flouse Flouse mentioned this pull request Mar 8, 2022
Closed
@Flouse Flouse self-requested a review March 8, 2022 15:57
@RetricSu RetricSu requested a review from classicalliu March 9, 2022 03:36
@Flouse Flouse merged commit 966844a into compatibility-breaking-changes Mar 9, 2022
@Flouse Flouse mentioned this pull request Mar 9, 2022
Closed
6 tasks
Flouse added a commit to godwokenrises/godwoken-kicker that referenced this pull request Mar 11, 2022
@Flouse
Update the web3 images
496d441 
- related PR
godwokenrises/godwoken-web3#199
@Flouse Flouse mentioned this pull request Mar 11, 2022
Merged
Flouse added a commit to godwokenrises/godwoken-kicker that referenced this pull request Mar 11, 2022
@Flouse
Update the web3 images
24660ed 
- related PR
godwokenrises/godwoken-web3#199
@Flouse Flouse deleted the fix-eth-hash branch March 11, 2022 11:04
Flouse added a commit to godwokenrises/godwoken-kicker that referenced this pull request Mar 11, 2022
@Flouse
Update the web3 images
e7d68fe 
- related PR
godwokenrises/godwoken-web3#199
Flouse added a commit to godwokenrises/godwoken-kicker that referenced this pull request Mar 12, 2022
@Flouse
Update the web3 images (#181)
e1ff913 
- related PR
godwokenrises/godwoken-web3#199
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@classicalliu classicalliu classicalliu approved these changes

@Flouse Flouse Flouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1: Check the Hashes of transactions from eth_getBlockByHash RPC
3 participants
@RetricSu @Flouse @classicalliu