-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Dict log for reqHeaders & resHeaders #965
Conversation
thx for the PR, but iam not really an expert for this MW |
@iredmail @raphielscape @dotX12 what do you think? |
Seems like a breaking change for me, but overall it's fine |
This will affect users who have header filters configured, for example, dashboards in Grafana, i.e. this is a serious change. But in the long run it looks sensible, I’m all for it. |
so it's a breaking change |
I would add a flag so that users can choose the format for listing headers.
maybe
or
In this case, we won't break anything :) |
76c4f2b
to
ecd8c11
Compare
Thx, without breaking done) |
ecd8c11
to
2e936c6
Compare
2e936c6
to
4e8d5ce
Compare
Hi, @ReneWerner87!
What do you think about it?
Was:
{"method":"POST"," header_key":"header_value"}
Became with sub dict:
{"method":"POST", "reqHeaders": {"header_key":"header_value"}}
{"method":"POST", "resHeaders": {"header_key":"header_value"}}