Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Update middleware to match helmet.js default values #91

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Update middleware to match helmet.js default values #91

merged 2 commits into from
Apr 10, 2023

Conversation

gaby
Copy link
Member

@gaby gaby commented Apr 7, 2023 •
edited
Loading

  • Updated the default values of the middleware to match the ones from Helmet.js.
  • Given that these may be considered "breaking changes", it may require bumping the minor version of the middleware.
  • Note, the tests are not testing the HSTS age headers, since that requires running a HTTPS server.

Source for default values: https://github.com/helmetjs/helmet#quick-start

Fixes #42

@gaby gaby changed the title Initial support to match Helmet.js default values Update middleware to match helmet.js default values Apr 7, 2023
@gaby gaby marked this pull request as ready for review April 7, 2023 04:42
@gaby gaby requested review from WLun001, ReneWerner87 and efectn April 7, 2023 04:43
@gaby
Copy link
Member Author

gaby commented Apr 8, 2023

This one should be ready for review @ReneWerner87

@ReneWerner87
Copy link
Member

Ok, tomorrow

efectn
efectn reviewed Apr 8, 2023
View reviewed changes
main.go Show resolved Hide resolved
@ReneWerner87 ReneWerner87 merged commit 0396b6c into master Apr 10, 2023
@gaby gaby deleted the fix-42 branch April 10, 2023 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@efectn efectn efectn approved these changes

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@WLun001 WLun001 Awaiting requested review from WLun001

Assignees
No one assigned
Labels
🧹 Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stricter default value
3 participants
@gaby @ReneWerner87 @efectn