-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module support #74
module support #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 4 4
Lines 279 279
=======================================
Hits 276 276
Misses 2 2
Partials 1 1 Continue to review full report at Codecov.
|
@carnott-snap Thank you for your contribution, but we won't be accepting this for now. We have chosen not to adopt modules at this time, with one of the reasons being that modules being introduced would require a major version bump ( Please see the following for more info behind why we made this choice: |
To clarify: we will look at Modules once they are no longer experimental / safe for use. |
@carnott-snap I guess to clarify even further: we had adopted Modules, and chose to remove it after there were problems with the community consuming our package. |
Ah, forgot we added a tl;dr to the README: https://github.com/gofrs/uuid/tree/6b08a5c5172ba18946672b49749cde22873dd7c2#go-111-modules |
@carnott-snap as @theckman mentioned, if you have existing packages that have already been tagged https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher If you are interested in more, Mark Bates recently put out a nicely done video that describes how to adopt modules from the perspective of a package maintainer. He runs through several options and examples. One of the examples he uses is how things are more confusing if the above best practice above is not followed, and how things are easier to understand if instead that best practice is followed. https://www.gopherguides.com/videos/go-modules-package-maintainers |
Go has released modules and while this repo does correctly tag releases, there is no
go.mod
file causing requires to look likejackfan.us.kg/gofrs/uuid v3.2.0+incompatible
.This change is backwards compatible, and should cause no breakage for existing customers.
After merge, a new tag should be pushed:
v3.2.1
.