Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(os/gview): search file faild from resource manager of package gres #4024

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

ynwcel
Copy link
Contributor

@ynwcel ynwcel commented Dec 10, 2024

  • bug:
    • gview:searchFile 尝试从 gres 里搜索文件出错
  • test
    • bug:
    • bug
    • fix:
    • fix

@gqcn
Copy link
Member

gqcn commented Dec 10, 2024

@ynwcel 感谢参与贡献,目前gres这块的代码正在做一些改进工作,以增加对fs.FS的支持,该PR预计需要挂一段时间,请知悉。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@ynwcel Thanks for participating in the contribution. The code of gres is currently undergoing some improvement work to add support for fs.FS. This PR is expected to take a while, please be informed.

@ynwcel
Copy link
Contributor Author

ynwcel commented Dec 11, 2024

@ynwcel 感谢参与贡献,目前gres这块的代码正在做一些改进工作,以增加对fs.FS的支持,该PR预计需要挂一段时间,请知悉。

@gqcn
修复不会涉及到 gres 。。只会涉及到 gview 的 searchFile 函数,修复之前函数内尝试通过 gres 查找视图文件时,gres 存在但查找失败,即使查找成功。因为 resouce 返回的是 nil 也会导致渲染为空。。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@ynwcel Thanks for participating in the contribution. The code of gres is currently undergoing some improvement work to add support for fs.FS. This PR is expected to take a while, please be informed.

The fix won't involve gres . . Only the searchFile function of gview is involved. When trying to find the view file through gres in the previous function, gres exists but the search fails, and the search succeeds immediately. Because resouce returns nil, it will also cause the rendering to be empty. .

os/gview/gview_parse.go Outdated Show resolved Hide resolved
os/gview/gview_parse.go Outdated Show resolved Hide resolved
os/gview/gview_parse.go Show resolved Hide resolved
@gqcn gqcn changed the title fix-gview-searchFile-faild-from-gres fix(os/gview): searchFile faild from package gres Dec 17, 2024
@gqcn gqcn changed the title fix(os/gview): searchFile faild from package gres fix(os/gview): search file faild from resource manager of package gres Dec 17, 2024
@gqcn gqcn added the ready to merge Used in PR, which means this PR is reviewed. label Dec 17, 2024
@gqcn gqcn changed the base branch from master to feat/v2.9.0 December 18, 2024 02:37
@gqcn gqcn merged commit 233295b into gogf:feat/v2.9.0 Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Used in PR, which means this PR is reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants