use only one write in the varint writer when possible #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps when calling `Write` is expensive and we'd rather not introduce another buffered writer. Note: this *also* fixes a bug where we'd try to use `MarshalTo` even if `getSize` failed.
bpot
added a commit
to bpot/go-bitswap
that referenced
this pull request
Mar 27, 2019
This reverts commit fc1278e. It appears that using a buffer here is no longer necessary after the upstream fix gogo/protobuf#504
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
This reverts commit 3ac3a96. It appears that using a buffer here is no longer necessary after the upstream fix gogo/protobuf#504 This commit was moved from ipfs/go-bitswap@c9aa374
hannahhoward
pushed a commit
to ipfs/go-protocolnetwork
that referenced
this pull request
Apr 7, 2023
This reverts commit 119f4cb. It appears that using a buffer here is no longer necessary after the upstream fix gogo/protobuf#504 This commit was moved from ipfs/go-bitswap@c9aa374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps when calling
Writeis expensive and we'd rather not introduce another buffered writer.Note: this also fixes a bug where we'd try to use
MarshalToeven ifgetSizefailed.