Pin versions for dependencies in Makefile #721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @dims @palnabarun |
|
I guess because it is used in CI and I am not familiar with godeps, it is after my time in go land. |
nikhita
force-pushed
the
golang/x/tools
branch
2 times, most recently
from
c9b6a48 to
78d05e3
Compare
nikhita
force-pushed
the
golang/x/tools
branch
from
78d05e3 to
98af289
Compare
nikhita
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indirect dependencies in
go.mod, specificallygolang.org/x/toolsandjackfan.us.kg/kisielk/errcheck, are not really used anywhere in the code.go mod tidyalso removes these lines. They are only used in theMakefileusinggo get.Currently, no version is specified while using
go get. This means that go will try to fetch the latest version and this version can deviate from the version ingo.mod. To avoid this, the PR updates the Makefile to explicitlygo getthe versions specified ingo.mod.Additionally, this PR also updates the versions to match the versions in
v1.3.1i.e. avoids the version bumps made in #717:github.com/kisielk/errchecktov1.2.0golang.org/x/toolstorelease-branch.go1.15Context - bumping gogo/protobuf from v1.3.1 to v1.3.2 in kubernetes requires bumping x/tools as well, which we'd like to avoid in k8s (xref kubernetes/client-go#927)
cc @awalterschulze