Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics for harbor #147

Merged
merged 3 commits into from
May 25, 2021
Merged

add metrics for harbor #147

merged 3 commits into from
May 25, 2021

Conversation

ninjadq
Copy link
Member

@ninjadq ninjadq commented Sep 16, 2020

No description provided.

@MartinForReal
Copy link

related: #103. I think comments provides a lot of useful information. FYI

* A new exporter component included in Harbor package
* colletct business logic data from DB
* Expose them as premetheus metric

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add what a user of Harbor will need to do to consume these metrics. ie how does he setup Prometheus, how does he subscribe to endpoints and metrics selectively, how does he request for additional metrics to be captured? @ninjadq

Copy link
Member Author

@ninjadq ninjadq Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I think we can add these kind of thing to document after code is freeze

@ninjadq
Copy link
Member Author

ninjadq commented Dec 10, 2020

@MartinForReal, it is really appreciate your proposal, we've read your proposal before. But in this proposal, we are focus on enabling the metrics on harbor. And provide an overall scaffold for people to add metrics. We will add more metrics in next steps, and will considering the proposal you posted.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's merge the implemented feature.

@perithompson
Copy link

Hi All, is this PR still being looked at it seems to have gone quiet?

@steven-zou
Copy link
Contributor

Lazy consensus and feature are delivered into 2.2.

@steven-zou steven-zou merged commit 0810708 into goharbor:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants