-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metrics for harbor #147
Conversation
045405d
to
406ef68
Compare
related: #103. I think comments provides a lot of useful information. FYI |
* A new exporter component included in Harbor package | ||
* colletct business logic data from DB | ||
* Expose them as premetheus metric | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add what a user of Harbor will need to do to consume these metrics. ie how does he setup Prometheus, how does he subscribe to endpoints and metrics selectively, how does he request for additional metrics to be captured? @ninjadq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I think we can add these kind of thing to document after code is freeze
Signed-off-by: DQ <[email protected]>
@MartinForReal, it is really appreciate your proposal, we've read your proposal before. But in this proposal, we are focus on enabling the metrics on harbor. And provide an overall scaffold for people to add metrics. We will add more metrics in next steps, and will considering the proposal you posted. |
Signed-off-by: DQ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's merge the implemented feature.
Hi All, is this PR still being looked at it seems to have gone quiet? |
Lazy consensus and feature are delivered into 2.2. |
No description provided.