add image.registry field #1003
Merged
add image.registry field #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengrongfu
force-pushed
the
feat/chart-add-registry
branch
3 times, most recently
from
6590e0b to
5bc00f1
Compare
lengrongfu
force-pushed
the
feat/chart-add-registry
branch
2 times, most recently
from
db32eb4 to
232b50c
Compare
|
Can you resolve the merge conflicts please? All the CI dependency issues should now be resolved. |
lengrongfu
force-pushed
the
feat/chart-add-registry
branch
from
232b50c to
5143574
Compare
lengrongfu
force-pushed
the
feat/chart-add-registry
branch
from
5143574 to
ccd49b2
Compare
|
@MarcelMue Sorry, I've been out of touch for a while. PTAL |
|
I think the code generation needs to be re-run. Are you aware how it works from the makefile? |
Signed-off-by: lengrongfu <[email protected]>
lengrongfu
force-pushed
the
feat/chart-add-registry
branch
from
ccd49b2 to
83cbcdc
Compare
MarcelMue
approved these changes
May 22, 2023
CoderTH
pushed a commit
to CoderTH/harbor-operator
that referenced
this pull request
May 23, 2023
Signed-off-by: lengrongfu <[email protected]> Signed-off-by: coderth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.