Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade controller-runtime version #1034

Merged
merged 1 commit into from
May 24, 2023
Merged

upgrade controller-runtime version #1034

merged 1 commit into from
May 24, 2023

Conversation

CoderTH
Copy link
Contributor

@CoderTH CoderTH commented May 14, 2023

issue #1033

@CoderTH CoderTH closed this May 19, 2023
@thcdrt
Copy link
Collaborator

thcdrt commented May 22, 2023 •
edited
Loading

Hello,
Why closing it ?

@CoderTH
Copy link
Contributor Author

CoderTH commented May 22, 2023

Hello, Why closing it ?

hello
There are still some problems in the code, there is no time to do it in the first two days, so it is closed temporarily. I will repair these problems and then reopen this PR

@CoderTH CoderTH reopened this May 22, 2023
@thcdrt
Copy link
Collaborator

thcdrt commented May 22, 2023

Ho ok, no problem. Tell me when you want us to review.

@CoderTH
Copy link
Contributor Author

CoderTH commented May 22, 2023

@thcdrt hi
can you help me run the ci pipeline ?

@CoderTH CoderTH force-pushed the master branch 5 times, most recently from 914ebdc to 0f0cfcc Compare May 22, 2023 16:10
@CoderTH
Copy link
Contributor Author

CoderTH commented May 22, 2023

Ho ok, no problem. Tell me when you want us to review.

please review this pr and help me run ci again

thcdrt
thcdrt approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@thcdrt thcdrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoderTH
Copy link
Contributor Author

CoderTH commented May 23, 2023

@thcdrt i don't know why theGenerated files are up to date and chart K8S xxx ci step error , can you take a look at it for me ？

@MarcelMue
Copy link
Collaborator

@thcdrt i don't know why theGenerated files are up to date and chart K8S xxx ci step error , can you take a look at it for me ？

There is a generate target in the makefile to generate all necessary files:

harbor-operator/Makefile

Lines 201 to 202 in 4cabfa9

.PHONY: generate
generate: go-generate helm-generate deployment-generate

@CoderTH CoderTH force-pushed the master branch 3 times, most recently from 85e6df2 to f7cd910 Compare May 23, 2023 08:10
@MarcelMue MarcelMue mentioned this pull request May 23, 2023
Merged
@thcdrt
Copy link
Collaborator

thcdrt commented May 23, 2023

Waiting for helm chart packaging fix before merging.

@MarcelMue
Copy link
Collaborator

Please rebase / resolve conflicts to see if we are good now 🙇‍♂️

@CoderTH
Copy link
Contributor Author

CoderTH commented May 24, 2023

Please rebase / resolve conflicts to see if we are good now 🙇‍♂️

ok, done please help me run ci again

@CoderTH
Copy link
Contributor Author

CoderTH commented May 24, 2023

@thcdrt @MarcelMue It look like ci pipeline is ok now

@CoderTH
Copy link
Contributor Author

CoderTH commented May 24, 2023

Thanks for your review and support 🙇 @thcdrt @MarcelMue
（But there doesn't seem to be an auto-merge

@MarcelMue MarcelMue merged commit 98058f8 into goharbor:master May 24, 2023
@MarcelMue
Copy link
Collaborator

I can merge - thanks for your help!

I will create a follow up issue to check if we need to do some more testing later on.

@CoderTH
Copy link
Contributor Author

CoderTH commented May 24, 2023 •
edited
Loading

I can merge - thanks for your help!

I will create a follow up issue to check if we need to do some more testing later on.

Ok, If there are any follow-up cases that I can help with, I would be happy to do so.

@MarcelMue
Copy link
Collaborator

Please check if everything in your projects which imports harbor operator works correctly now :)

I think we mostly need some more test cases for current and new functionality, but there is nothing I can point you to right now

@MarcelMue MarcelMue mentioned this pull request May 24, 2023
Closed
DeeAjayi pushed a commit to giantswarm/harbor-operator-upstream that referenced this pull request May 24, 2023
@CoderTH @DeeAjayi
upgrade controller-runtime version (goharbor#1034)
00f8b09 
upgrade controller runtime version

Signed-off-by: coderth <[email protected]>
Signed-off-by: Dipo Ajayi <[email protected]>
MarcelMue pushed a commit that referenced this pull request May 25, 2023
@DeeAjayi @CoderTH @zlangi
Add Redis service account name to CRD (#1001)
ba4d731 
* upgrade controller-runtime version (#1034)

upgrade controller runtime version

Signed-off-by: coderth <[email protected]>
Signed-off-by: Dipo Ajayi <[email protected]>

* Add the missing github-cr proxy cache module (#1035)

Add the missing github proxy cache module

Signed-off-by: Zoltan Langi <[email protected]>
Co-authored-by: Zoltan Langi <[email protected]>
Signed-off-by: Dipo Ajayi <[email protected]>

* Add service account name to cr (#3)

* Included Service Account to Redis CR

Signed-off-by: Oladipupo Ajayi <[email protected]>

* Revert deployment change

Signed-off-by: Oladipupo Ajayi <[email protected]>
Signed-off-by: Dipo Ajayi <[email protected]>

---------

Signed-off-by: coderth <[email protected]>
Signed-off-by: Dipo Ajayi <[email protected]>
Signed-off-by: Zoltan Langi <[email protected]>
Signed-off-by: Oladipupo Ajayi <[email protected]>
Co-authored-by: Noah Tang <[email protected]>
Co-authored-by: Zoltan <[email protected]>
Co-authored-by: Zoltan Langi <[email protected]>
devinturner pushed a commit to plotly/harbor-operator that referenced this pull request Jun 23, 2023
@CoderTH @devinturner
upgrade controller-runtime version (goharbor#1034)
3ebbf62 
upgrade controller runtime version

Signed-off-by: coderth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelMue MarcelMue MarcelMue approved these changes

@thcdrt thcdrt thcdrt approved these changes

Assignees

@holyhope holyhope

@thcdrt thcdrt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CoderTH @thcdrt @MarcelMue @holyhope