fix(ci) support certmanager 1.4 #697
Conversation
bitsf
force-pushed
the
fix_certmanager_1.4
branch
from
07a9ea1 to
edf7574
Compare
bitsf
force-pushed
the
fix_certmanager_1.4
branch
3 times, most recently
from
6435107 to
b410548
Compare
Signed-off-by: Ziming Zhang <[email protected]>
bitsf
force-pushed
the
fix_certmanager_1.4
branch
from
b410548 to
1a4afc0
Compare
| @@ -221,6 +221,8 @@ jobs: | |||
| exit 1 | |||
| fi | |||
|
|
|||
| sleep 10 | |||
There was a problem hiding this comment.
| sleep 10 | |
| time kubectl wait -n ${operatorNamespace} pod --selector=control-plane=harbor-operator --timeout=300s |
It seems possible to use this
There was a problem hiding this comment.
前面已经 wait deployment 了，此处怀疑是 harbor-operator 即便都已经部署成功了，webhook 也需要点时间才能生效，所以简单的 sleep
There was a problem hiding this comment.
Not that easy to understand the response, but I agree with @cndoit18 's suggestion
There was a problem hiding this comment.
前面已经 wait deployment 了，此处怀疑是 harbor-operator 即便都已经部署成功了，webhook 也需要点时间才能生效，所以简单的 sleep
@bitsf next time, you should leave an English message.
And will you do change for that part?
There was a problem hiding this comment.
This sleep 10 is just to workaround CI failed sometimes recently, because webhook seems not started even we already using kubectl wait deployment
| @@ -221,6 +221,8 @@ jobs: | |||
| exit 1 | |||
| fi | |||
|
|
|||
| sleep 10 | |||
There was a problem hiding this comment.
Not that easy to understand the response, but I agree with @cndoit18 's suggestion
| @@ -82,7 +82,7 @@ func (r *Reconciler) GetNotarySignerCertificateAuthority(ctx context.Context, ha | |||
| Duration: &metav1.Duration{ | |||
| Duration: duration, | |||
| }, | |||
| CommonName: r.NormalizeName(ctx, harbor.GetName(), controllers.NotarySigner.String()), | |||
| CommonName: r.NormalizeName(ctx, harbor.GetName(), controllers.NotarySigner.String(), "CA"), | |||
There was a problem hiding this comment.
How does this fix cert-manager v1.4 compatibility?
There was a problem hiding this comment.
cert-manger 1.4 doesn't allow using same CN between Cert and CA, so I added a suffix to distinguish them
close #693