-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Use RegisteredClaims instead of deprecated staruct StandardClaims #16206
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## main #16206 +/- ##
==========================================
- Coverage 67.16% 67.12% -0.05%
==========================================
Files 979 979
Lines 81776 81778 +2
Branches 2604 2604
==========================================
- Hits 54922 54890 -32
- Misses 23103 23137 +34
Partials 3751 3751
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@wujunwei could you help to fix the CI failure? Then, I'll merge it. |
@wujunwei Thanks for contributing to Harbor. Could you please rebase the latest main branch into your branch and then force push your branch to this PR? |
I had do that , anything thing I should do ? |
@wujunwei Thanks for your contribution! Could you please rebase latest main branch into your branch again and squash your commits into one. Thanks. |
Hi @wujunwei , Apologize for reaching you late until now and would you like to keep working on this PR? Best, |
@MinerYang @zyyw I have squashed my commits into one and force push to this branch , did I do it right? |
It seems that the |
It failed at notary sign image test and probably due to the token reason. I would look into this first and hold this PR until it's not a broken change. Best, |
…laims Signed-off-by: wujw39640 <[email protected]>
I have found why |
I have fixed all the CI failure @wy65701436 : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…laims (goharbor#16206) Signed-off-by: wujw39640 <[email protected]>
…laims (goharbor#16206) Signed-off-by: wujw39640 <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
StandardClaims are Deprecated and may might lead to incompatibilities with other JWT implementations. The use of this is discouraged.
Use RegisteredClaims instead for a forward-compatible way to access registered claims in a struct.
Signed-off-by: wujunwei [email protected]