Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of angular #17303

Merged
merged 5 commits into from
Aug 17, 2022

Conversation

mrbusche
Copy link
Contributor

@mrbusche mrbusche commented Aug 3, 2022

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Updated to Angular 14 using the Angular Update Guide

Issue being fixed

  • Fixes: Angular is a major version behind
  • Labels: I'm not able to add labels but release-note/enhancement is appropriate
  • Unit tests pass locally
  • One docs page (that I found) affected has been updated

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@mrbusche mrbusche marked this pull request as ready for review August 3, 2022 03:45
@mrbusche mrbusche requested a review from a team as a code owner August 3, 2022 03:45
@mrbusche
Copy link
Contributor Author

mrbusche commented Aug 8, 2022

Can I get someone to approve this PR for status checks, please?

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #17303 (d836397) into main (f913b84) will increase coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17303      +/-   ##
==========================================
+ Coverage   67.03%   67.08%   +0.04%     
==========================================
  Files         993      993              
  Lines       83661    83638      -23     
  Branches     2676     2632      -44     
==========================================
+ Hits        56084    56110      +26     
+ Misses      23698    23678      -20     
+ Partials     3879     3850      -29     
Flag Coverage Δ
unittests 67.08% <75.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ion/create-edit-rule/create-edit-rule.component.ts 35.25% <50.00%> (+0.40%) ⬆️
...ner/new-scanner-form/new-scanner-form.component.ts 72.16% <100.00%> (ø)
...tal/src/app/oidc-onboard/oidc-onboard.component.ts 60.00% <100.00%> (ø)
...nts/image-name-input/image-name-input.component.ts 40.00% <100.00%> (ø)
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
...rc/app/base/left-side-nav/config/config.service.ts 56.75% <0.00%> (ø)
...-robot-accounts/system-robot-accounts.component.ts 33.51% <0.00%> (+0.18%) ⬆️
...ry/artifact/artifact-tag/artifact-tag.component.ts 32.48% <0.00%> (+0.20%) ⬆️
...e/project/robot-account/robot-account.component.ts 34.45% <0.00%> (+0.23%) ⬆️
...t/artifact-list-tab/artifact-list-tab.component.ts 30.14% <0.00%> (+0.28%) ⬆️
... and 21 more

@mrbusche
Copy link
Contributor Author

mrbusche commented Aug 9, 2022

Looks like we need to wait for @clr/angular to release version 14 before we can use angular:14

Doesn't sound like it will actually cause problems, but here's the issue to update to Angular 14 for @clr/angular vmware-clarity/ng-clarity#95

13:49:48 + npm install -q --no-progress
13:49:50 npm ERR! code ERESOLVE
13:49:50 npm ERR! ERESOLVE could not resolve
13:49:50 npm ERR!
13:49:50 npm ERR! While resolving: @clr/[email protected]
13:49:50 npm ERR! Found: @angular/[email protected]
13:49:50 npm ERR! node_modules/@angular/common
13:49:50 npm ERR! @angular/common@"^14.1.0" from the root project
13:49:50 npm ERR! peer @angular/common@"14.1.0" from @angular/[email protected]
13:49:50 npm ERR! node_modules/@angular/forms
13:49:50 npm ERR! @angular/forms@"^14.1.0" from the root project
13:49:50 npm ERR! 7 more (@angular/platform-browser, ...)
13:49:50 npm ERR!
13:49:50 npm ERR! Could not resolve dependency:
13:49:50 npm ERR! peer @angular/common@"^13.0.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/angular
13:49:50 npm ERR! @clr/angular@"13.3.0" from the root project
13:49:50 npm ERR! peer @clr/angular@"13.3.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/ui
13:49:50 npm ERR! @clr/ui@"13.3.0" from the root project
13:49:50 npm ERR!
13:49:50 npm ERR! Conflicting peer dependency: @angular/[email protected]
13:49:50 npm ERR! node_modules/@angular/common
13:49:50 npm ERR! peer @angular/common@"^13.0.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/angular
13:49:50 npm ERR! @clr/angular@"13.3.0" from the root project
13:49:50 npm ERR! peer @clr/angular@"13.3.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/ui
13:49:50 npm ERR! @clr/ui@"13.3.0" from the root project

@AllForNothing
Copy link
Contributor

@mrbusche That's true.
I have consulted the Clarity team about the release plan for 14, let's wait for the updates

@AllForNothing
Copy link
Contributor

@mrbusche Refer to this,vmware-clarity/ng-clarity#274
Would you like to try Clarity version 13.6.x

Signed-off-by: Matt Busche <[email protected]>
Signed-off-by: Matt Busche <[email protected]>
@mrbusche
Copy link
Contributor Author

@mrbusche Refer to this,vmware-clarity/ng-clarity#274 Would you like to try Clarity version 13.6.x

I updated the Clarity version and also had to update ngx-markdown, but everything should be good.

I'd be happy to do another run through of updates once this one is merged.

@AllForNothing
Copy link
Contributor

@mrbusche I will run the e2e cases first, then merge this PR if no breaking change

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllForNothing AllForNothing merged commit 548b27a into goharbor:main Aug 17, 2022
@mrbusche mrbusche deleted the update-angular branch August 18, 2022 01:32
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
* Update to the latest version of angular

Signed-off-by: Matt Busche <[email protected]>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
* Update to the latest version of angular

Signed-off-by: Matt Busche <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants