-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest version of angular #17303
Conversation
Signed-off-by: Matt Busche <[email protected]>
b6acabf
to
d324c57
Compare
Can I get someone to approve this PR for status checks, please? |
Codecov Report
@@ Coverage Diff @@
## main #17303 +/- ##
==========================================
+ Coverage 67.03% 67.08% +0.04%
==========================================
Files 993 993
Lines 83661 83638 -23
Branches 2676 2632 -44
==========================================
+ Hits 56084 56110 +26
+ Misses 23698 23678 -20
+ Partials 3879 3850 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks like we need to wait for Doesn't sound like it will actually cause problems, but here's the issue to update to Angular 14 for 13:49:48 + npm install -q --no-progress
13:49:50 npm ERR! code ERESOLVE
13:49:50 npm ERR! ERESOLVE could not resolve
13:49:50 npm ERR!
13:49:50 npm ERR! While resolving: @clr/[email protected]
13:49:50 npm ERR! Found: @angular/[email protected]
13:49:50 npm ERR! node_modules/@angular/common
13:49:50 npm ERR! @angular/common@"^14.1.0" from the root project
13:49:50 npm ERR! peer @angular/common@"14.1.0" from @angular/[email protected]
13:49:50 npm ERR! node_modules/@angular/forms
13:49:50 npm ERR! @angular/forms@"^14.1.0" from the root project
13:49:50 npm ERR! 7 more (@angular/platform-browser, ...)
13:49:50 npm ERR!
13:49:50 npm ERR! Could not resolve dependency:
13:49:50 npm ERR! peer @angular/common@"^13.0.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/angular
13:49:50 npm ERR! @clr/angular@"13.3.0" from the root project
13:49:50 npm ERR! peer @clr/angular@"13.3.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/ui
13:49:50 npm ERR! @clr/ui@"13.3.0" from the root project
13:49:50 npm ERR!
13:49:50 npm ERR! Conflicting peer dependency: @angular/[email protected]
13:49:50 npm ERR! node_modules/@angular/common
13:49:50 npm ERR! peer @angular/common@"^13.0.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/angular
13:49:50 npm ERR! @clr/angular@"13.3.0" from the root project
13:49:50 npm ERR! peer @clr/angular@"13.3.0" from @clr/[email protected]
13:49:50 npm ERR! node_modules/@clr/ui
13:49:50 npm ERR! @clr/ui@"13.3.0" from the root project |
@mrbusche That's true. |
@mrbusche Refer to this,vmware-clarity/ng-clarity#274 |
Signed-off-by: Matt Busche <[email protected]>
Signed-off-by: Matt Busche <[email protected]>
723d0bc
to
494cd79
Compare
Signed-off-by: Matt Busche <[email protected]>
afebc1b
to
22e0bca
Compare
Signed-off-by: Matt Busche <[email protected]>
I updated the Clarity version and also had to update ngx-markdown, but everything should be good. I'd be happy to do another run through of updates once this one is merged. |
@mrbusche I will run the e2e cases first, then merge this PR if no breaking change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update to the latest version of angular Signed-off-by: Matt Busche <[email protected]>
* Update to the latest version of angular Signed-off-by: Matt Busche <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Updated to Angular 14 using the Angular Update Guide
Issue being fixed
release-note/enhancement
is appropriatePlease indicate you've done the following: