Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add GetRedisURL to tests redis pkg and fix hardcoded redis url #17581

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

gaius-qi
Copy link
Contributor

@gaius-qi gaius-qi commented Sep 20, 2022

Signed-off-by: Gaius [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

  • Add GetRedisURL to src/jobservice/tests pkg.
  • Fix hardcoded redis url in src/jobservice/job/impl/gc/garbage_collection_test.go.

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@gaius-qi gaius-qi requested a review from a team as a code owner September 20, 2022 10:03
@gaius-qi
Copy link
Contributor Author

@bitsf @chlins Thank you!

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #17581 (d85b072) into main (3d8959b) will decrease coverage by 4.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17581      +/-   ##
==========================================
- Coverage   71.69%   67.38%   -4.31%     
==========================================
  Files         758      995     +237     
  Lines       70929    83938   +13009     
  Branches        0     2606    +2606     
==========================================
+ Hits        50850    56565    +5715     
- Misses      16513    23526    +7013     
- Partials     3566     3847     +281     
Flag Coverage Δ
unittests 67.38% <ø> (-4.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/auditlog/auditlog.go 8.69% <0.00%> (-52.18%) ⬇️
src/common/rbac/system/namespace.go 33.33% <0.00%> (-11.12%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-9.01%) ⬇️
...ation-services/scanner/config-scanner.component.ts 48.48% <0.00%> (ø)
...e-integration/tag-feature-integration.component.ts 100.00% <0.00%> (ø)
...oject/webhook/add-webhook/add-webhook.component.ts 50.00% <0.00%> (ø)
src/portal/src/app/services/theme.service.ts 81.81% <0.00%> (ø)
...es/vulnerability/vulnerability-config.component.ts 54.07% <0.00%> (ø)
...etail/chart-detail/chart-detail-value.component.ts 43.75% <0.00%> (ø)
...ared/components/push-image/copy-input.component.ts 61.11% <0.00%> (ø)
... and 230 more

@gaius-qi
Copy link
Contributor Author

@chlins @stonezdj How can i pass the ci ?

@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Sep 28, 2022
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi
Copy link
Contributor Author

@chlins Can we merge this PR ? 😊

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 25a42af into goharbor:main Oct 17, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants