-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add GetRedisURL to tests redis pkg and fix hardcoded redis url #17581
Conversation
Signed-off-by: Gaius <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #17581 +/- ##
==========================================
- Coverage 71.69% 67.38% -4.31%
==========================================
Files 758 995 +237
Lines 70929 83938 +13009
Branches 0 2606 +2606
==========================================
+ Hits 50850 56565 +5715
- Misses 16513 23526 +7013
- Partials 3566 3847 +281
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@chlins Can we merge this PR ? 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…oharbor#17581) Signed-off-by: Gaius <[email protected]> Signed-off-by: Stephan Hohn <[email protected]>
Signed-off-by: Gaius [email protected]
Thank you for contributing to Harbor!
Comprehensive Summary of your change
GetRedisURL
tosrc/jobservice/tests
pkg.src/jobservice/job/impl/gc/garbage_collection_test.go
.Issue being fixed
Fixes #(issue)
Please indicate you've done the following: