Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REST API to list job queue status, pause/resume job queue and list schedulers #17707

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add REST API to list job queue status, pause/resume job queue and list schedulers #17707

merged 1 commit into from
Nov 17, 2022

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Oct 27, 2022 •
edited
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner October 27, 2022 10:04
@codecov
Copy link

codecov bot commented Oct 27, 2022 •
edited
Loading

Codecov Report

Merging #17707 (29830b1) into main (39ca918) will decrease coverage by 22.52%.
The diff coverage is n/a.

❗ Current head 29830b1 differs from pull request most recent head c13a255. Consider uploading reports for the commit c13a255 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #17707       +/-   ##
===========================================
- Coverage   66.56%   44.04%   -22.53%     
===========================================
  Files        1000      235      -765     
  Lines      106956    12942    -94014     
  Branches     2609     2597       -12     
===========================================
- Hits        71196     5700    -65496     
+ Misses      31841     6960    -24881     
+ Partials     3919      282     -3637
Flag Coverage Δ
unittests 44.04% <ø> (-22.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...portal/src/app/shared/directives/port.directive.ts 26.66% <0.00%> (-46.67%) ⬇️
...audit-log-purge/history/purge-history.component.ts 40.69% <0.00%> (-5.82%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (-4.45%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 30.55% <0.00%> (-3.57%) ⬇️
...count-settings/account-settings-modal.component.ts 74.07% <0.00%> (-1.56%) ⬇️
src/portal/src/app/shared/units/utils.ts 59.81% <0.00%> (-1.23%) ⬇️
src/controller/jobmonitor/monitor.go
src/controller/jobservice/schedule.go
src/jobservice/runtime/bootstrap.go
src/jobservice/sync/schedule.go
... and 765 more

@stonezdj stonezdj force-pushed the feature_jobservice_pw_qs branch 3 times, most recently from b07b9a3 to 81551d1 Compare October 28, 2022 07:05
@stonezdj stonezdj changed the title [WIP] Add REST API to list job queue status, pause/resume job queue and list schedulers Add REST API to list job queue status, pause/resume job queue and list schedulers Oct 28, 2022
@stonezdj stonezdj requested review from wy65701436 and chlins October 31, 2022 06:24
@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label Oct 31, 2022
@stonezdj stonezdj force-pushed the feature_jobservice_pw_qs branch 3 times, most recently from 0ec3dd8 to 1e8f961 Compare November 4, 2022 09:11
chlins
chlins reviewed Nov 7, 2022
View reviewed changes
api/v2.0/swagger.yaml Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Outdated Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Outdated Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Outdated Show resolved Hide resolved
@stonezdj stonezdj force-pushed the feature_jobservice_pw_qs branch from 1e8f961 to eac36d5 Compare November 7, 2022 07:52
@stonezdj stonezdj force-pushed the feature_jobservice_pw_qs branch 10 times, most recently from 29830b1 to b62e5a3 Compare November 10, 2022 12:13
@stonezdj stonezdj force-pushed the feature_jobservice_pw_qs branch from b62e5a3 to 3f204bc Compare November 11, 2022 06:41
chlins
chlins approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Nov 15, 2022
Closed
Closed
wy65701436
wy65701436 reviewed Nov 15, 2022
View reviewed changes
src/controller/jobmonitor/monitor.go Outdated Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Outdated Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Outdated Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Outdated Show resolved Hide resolved
src/pkg/jobmonitor/redis.go Show resolved Hide resolved
src/controller/jobservice/schedule.go Outdated Show resolved Hide resolved
api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
src/controller/jobmonitor/monitor.go Show resolved Hide resolved
make/migrations/postgresql/0100_2.7.0_schema.up.sql Outdated Show resolved Hide resolved
@stonezdj stonezdj force-pushed the feature_jobservice_pw_qs branch 8 times, most recently from 637cc17 to 205ef41 Compare November 17, 2022 03:42
wy65701436
wy65701436 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
Add REST API to list job queue status, pause/resume job queue and lis…
c13a255 
…t schedulers

  Add queue manager and redis client
  Update scheduler to add count and list

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the feature_jobservice_pw_qs branch from 205ef41 to c13a255 Compare November 17, 2022 09:04
@stonezdj stonezdj merged commit 57aff88 into goharbor:main Nov 17, 2022
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
@stonezdj
Add REST API to list job queue status, pause/resume job queue and lis…
a571c89 
…t schedulers (goharbor#17707)

Add queue manager and redis client
  Update scheduler to add count and list

Signed-off-by: stonezdj <[email protected]>

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@chlins chlins chlins approved these changes

Assignees

@wy65701436 wy65701436

@chlins chlins

Labels
release-note/new-feature New Harbor Feature target/2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stonezdj @wy65701436 @chlins