Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort group search result by most match order #17708

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Oct 27, 2022

fixes #17535

Signed-off-by: stonezdj [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner October 27, 2022 10:15
@stonezdj stonezdj added release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.7.0 labels Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #17708 (2735be0) into main (0acfbdc) will increase coverage by 0.01%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17708      +/-   ##
==========================================
+ Coverage   66.60%   66.62%   +0.01%     
==========================================
  Files         995      995              
  Lines      105898   105913      +15     
  Branches     2602     2602              
==========================================
+ Hits        70536    70563      +27     
+ Misses      31464    31453      -11     
+ Partials     3898     3897       -1     
Flag Coverage Δ
unittests 66.62% <62.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/v2.0/handler/usergroup.go 5.81% <62.50%> (+5.81%) ⬆️
...g-retention-tasks/tag-retention-tasks.component.ts 61.11% <0.00%> (-25.00%) ⬇️
src/lib/cache/util.go 73.07% <0.00%> (-15.39%) ⬇️
src/jobservice/runner/redis.go 71.18% <0.00%> (+4.51%) ⬆️
src/controller/event/topic.go 8.45% <0.00%> (+6.33%) ⬆️
src/core/api/internal.go 44.82% <0.00%> (+8.62%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 60.71% <0.00%> (+28.57%) ⬆️

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit ea27197 into goharbor:main Nov 15, 2022
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
fixes goharbor#17535

Signed-off-by: stonezdj <[email protected]>

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP groups cannot be added as project members if 10 or more other groups extend their name
3 participants