Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove email config page #17711

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Remove email config page #17711

merged 1 commit into from
Nov 3, 2022

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Oct 28, 2022 •
edited
Loading

Fixes #17683

  1. Remove email config page as it is useless

Signed-off-by: AllForNothing [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Remove email config page
987850f 
Signed-off-by: AllForNothing <[email protected]>
@AllForNothing AllForNothing requested a review from a team as a code owner October 28, 2022 04:52
@AllForNothing AllForNothing added the release-note/deprecation Harbor Deprecation MUST need to be in release notes label Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #17711 (987850f) into main (6f4d84e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17711      +/-   ##
==========================================
- Coverage   66.62%   66.60%   -0.02%     
==========================================
  Files         995      994       -1     
  Lines      105898   105841      -57     
  Branches     2602     2591      -11     
==========================================
- Hits        70555    70496      -59     
- Misses      31445    31451       +6     
+ Partials     3898     3894       -4
Flag Coverage Δ
unittests 66.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...portal/src/app/shared/directives/port.directive.ts 26.66% <0.00%> (-46.67%) ⬇️
src/lib/cache/util.go 73.07% <0.00%> (-15.39%) ⬇️
src/common/rbac/system/namespace.go 35.29% <0.00%> (-11.77%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 54.07% <0.00%> (-4.45%) ⬇️
src/portal/src/app/shared/units/utils.ts 59.81% <0.00%> (-1.23%) ⬇️
src/common/utils/passports.go 90.19% <0.00%> (+3.92%) ⬆️

wy65701436
wy65701436 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 93ac2e8 into goharbor:main Nov 3, 2022
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Nov 7, 2022
Remove email config testcases
a103eeb 
Because the email config page has been removed goharbor#17711

Signed-off-by: Yang Jiao <[email protected]>
@YangJiao0817 YangJiao0817 mentioned this pull request Nov 8, 2022
Merged
5 tasks
YangJiao0817 added a commit that referenced this pull request Nov 8, 2022
@YangJiao0817
Remove email config testcases (#17763)
e2e8f00 
Because the email config page has been removed #17711

Signed-off-by: Yang Jiao <[email protected]>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
@AllForNothing
Remove email config page (goharbor#17711)
e0e542d 
Signed-off-by: AllForNothing <[email protected]>

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
@YangJiao0817
Remove email config testcases (goharbor#17763)
5e6af52 
Because the email config page has been removed goharbor#17711

Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Stephan Hohn <[email protected]>
@AllForNothing AllForNothing deleted the remove-email branch March 29, 2023 05:18
@adberger adberger mentioned this pull request Sep 14, 2024
Merged
flbla added a commit to goharbor/terraform-provider-harbor that referenced this pull request Oct 23, 2024
@adberger @flbla
chore: Remove deprecated email configuration (#469)
63844e9 
The email configuration was removed from harbor in v2.7.0.
According to the `README.md` in this repository the supported versions
are >2.9.

Therefore this PR intends to remove the email configuration from the
terraform provider.

Related PRs:
- goharbor/harbor#17711
- goharbor/harbor#17712

Signed-off-by: Adrian Berger <[email protected]>
Co-authored-by: Florian Blampey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

@stonezdj stonezdj Awaiting requested review from stonezdj

Assignees

@AllForNothing AllForNothing

Labels
release-note/deprecation Harbor Deprecation MUST need to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove E-mail config page
4 participants
@AllForNothing @wy65701436 @YangJiao0817 @stonezdj