Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow robot accounts to create artifacts #17905

Closed

Conversation

monofone
Copy link
Contributor

@monofone monofone commented Dec 2, 2022

Comprehensive Summary of your change

currently the GUI does not support selecting "create artifact" this is needed to allow the robot account to copy artifacts

Issue being fixed

Addition to #8723

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@monofone monofone requested a review from a team as a code owner December 2, 2022 22:58
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #17905 (6928183) into main (2f5827a) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17905      +/-   ##
==========================================
+ Coverage   66.43%   66.47%   +0.03%     
==========================================
  Files        1012     1017       +5     
  Lines      108543   112811    +4268     
  Branches     2673     3093     +420     
==========================================
+ Hits        72114    74992    +2878     
- Misses      32472    33488    +1016     
- Partials     3957     4331     +374     
Flag Coverage Δ
unittests 66.44% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ide-nav/system-robot-accounts/system-robot-util.ts 59.01% <ø> (-8.49%) ⬇️
src/pkg/reg/model/resource.go 62.50% <0.00%> (-20.84%) ⬇️
.../app/shared/directives/date-validator.directive.ts 44.44% <0.00%> (-8.89%) ⬇️
...shared/components/navigator/navigator.component.ts 34.48% <0.00%> (-7.71%) ⬇️
...ide-nav/config/system/system-settings.component.ts 43.05% <0.00%> (-6.95%) ⬇️
.../shared/router-guard/auth-user-activate.service.ts 17.14% <0.00%> (-5.94%) ⬇️
...omponents/global-search/global-search.component.ts 67.34% <0.00%> (-5.16%) ⬇️
...board/job-service-dashboard-shared-data.service.ts 12.69% <0.00%> (-4.70%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 58.51% <0.00%> (-4.45%) ⬇️
... and 106 more

@monofone
Copy link
Contributor Author

monofone commented Dec 2, 2022

@wy65701436 Where / how to accept DCO ?

@Vad1mo Vad1mo added the release-note/update Update or Fix label Dec 4, 2022
@Vad1mo
Copy link
Member

Vad1mo commented Dec 4, 2022

@wy65701436 Where / how to accept DCO ?

@monofone see here https://probot.github.io/apps/dco/

currently the GUI does not support selecting "create artifact"
this is needed to allow the robot account to copy artifacts

Signed-off-by: Sören Rohweder <[email protected]>
@monofone monofone force-pushed the 8723-allow-robot-create-artifact branch from 052c5f3 to 6928183 Compare December 4, 2022 11:31
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Mar 5, 2023
@Vad1mo Vad1mo removed the Stale label Mar 5, 2023
@Vad1mo Vad1mo reopened this Mar 5, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label May 5, 2023
@wy65701436
Copy link
Contributor

hi @monofone our objective is to make more permissions available in the UI candidate list. We're considering an idea to include all permissions, but with different dimensions like category and operations. However, before moving forward with this idea, I think it's best to stick with the current list and avoid adding permissions one by one.

cc @Vad1mo

@github-actions github-actions bot removed the Stale label May 18, 2023
@wy65701436
Copy link
Contributor

since we have this PR to cover all the API, so I suggest that we can close this one. @monofone @Vad1mo ?

@monofone
Copy link
Contributor Author

monofone commented Jun 8, 2023

@wy65701436 fine for me.

@wy65701436 wy65701436 closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants