Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the testcase for v2.12.0, changes include #21113

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

stonezdj
Copy link
Contributor

pull image from registry.goharbor.io instead of dockerhub
Update testcase to support Docker Image Can Be Pulled With Credential
Change gitlab project name when user changed.
Update permissions count and permission count total
Change webhook_endpoint_ui

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj added the release-note/ignore-for-release Do not include PR or Issue for release notes label Oct 30, 2024
@stonezdj stonezdj requested a review from a team as a code owner October 30, 2024 05:58
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

   pull image from registry.goharbor.io instead of dockerhub
   Update testcase to support Docker Image Can Be Pulled With Credential
   Change gitlab project name when user changed.
   Update permissions count and permission count total
   Change webhook_endpoint_ui

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 24oc530_update_testcase branch from 7c82bca to 8d786a3 Compare October 30, 2024 06:36
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.07%. Comparing base (c8c11b4) to head (e63f8ab).
Report is 312 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21113       +/-   ##
===========================================
+ Coverage   45.36%   66.07%   +20.70%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114649   +101316     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75757    +69708     
- Misses       6983    34744    +27761     
- Partials      301     4148     +3847     
Flag Coverage Δ
unittests 66.07% <ø> (+20.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

@wy65701436 wy65701436 merged commit 9e55afb into goharbor:main Oct 30, 2024
18 checks passed
ianseyer pushed a commit to ianseyer/harbor that referenced this pull request Feb 3, 2025
pull image from registry.goharbor.io instead of dockerhub
   Update testcase to support Docker Image Can Be Pulled With Credential
   Change gitlab project name when user changed.
   Update permissions count and permission count total
   Change webhook_endpoint_ui

Signed-off-by: stonezdj <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants