Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lint Check for Copyright Headers in UI #21692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Lint Check for Copyright Headers in UI #21692

wants to merge 1 commit into from

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Mar 5, 2025 •
edited by Vad1mo
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #21628 partly

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/update"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd marked this pull request as ready for review March 5, 2025 07:58
@bupd bupd requested a review from a team as a code owner March 5, 2025 07:58
@bupd bupd changed the title (WIP): Add Lint Check for Copyright Headers in UI Add Lint Check for Copyright Headers in UI Mar 5, 2025
@bupd bupd mentioned this pull request Mar 5, 2025
Open
@Vad1mo Vad1mo added the release-note/update Update or Fix label Mar 5, 2025
@Vad1mo Vad1mo enabled auto-merge (squash) March 5, 2025 09:14
auto-merge was automatically disabled March 5, 2025 10:43

Head branch was pushed to by a user without write access

chlins
chlins approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vad1mo Vad1mo Vad1mo approved these changes

@chlins chlins chlins approved these changes

Assignees

@Vad1mo Vad1mo

@stonezdj stonezdj

@MinerYang MinerYang

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why Harbor UI files have mixed copyrights
5 participants
@bupd @Vad1mo @chlins @stonezdj @MinerYang