Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Vmware to goharbor #21696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace Vmware to goharbor #21696

wants to merge 1 commit into from

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Mar 5, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

This is the final PR for replacing vmware with goharbor.

Issue being fixed

Fixes #21628

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd marked this pull request as ready for review March 5, 2025 07:59
@bupd bupd requested a review from a team as a code owner March 5, 2025 07:59
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.40%. Comparing base (c8c11b4) to head (f40c8e1).
Report is 399 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21696      +/-   ##
==========================================
+ Coverage   45.36%   46.40%   +1.03%     
==========================================
  Files         244      250       +6     
  Lines       13333    14133     +800     
  Branches     2719     2908     +189     
==========================================
+ Hits         6049     6558     +509     
- Misses       6983     7229     +246     
- Partials      301      346      +45     
Flag Coverage Δ
unittests 46.40% <ø> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 494 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why Harbor UI files have mixed copyrights
5 participants