Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue: harbor 1.7.4 aliyun oss chartmuseum 500 #7750

Merged
merged 1 commit into from
May 16, 2019

Conversation

liqiang-fit2cloud
Copy link
Contributor

@liqiang-fit2cloud liqiang-fit2cloud commented May 9, 2019

Signed-off-by: liqiang-fit2cloud [email protected]

Fix #7288

The issue occurs when using Alibaba OSS for both docker registry and helm chart repository, the endpoint must be specified in the registry_storage_provider_config of harbor.cfg file as the endpoint is mandatory for helm chart, although it's optional for docker registry .
For docker registry the endpoint must contain the bucket name like bucket-name.oss-cn-qingdao-internal.aliyuncs.com, But for helm chart the endpoint must be in the format oss-cn-qingdao-internal.aliyuncs.com which should not contains bucket name.
So if set the endpoint with bucket name docker registry works well but helm chart is not working, if set the endpoint without bucket name docker registry is not working but helm chart works well, it's awkward...

With this PR, the bucket name will be removed from the endpoint for helm chart, both docker registry and helm chart work well.

Signed-off-by: liqiang-fit2cloud <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12739

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 64.55%

Files with Coverage Reduction New Missed Lines %
src/core/api/repository.go 3 43.62%
Totals Coverage Status
Change from base Build 12733: -0.01%
Covered Lines: 15967
Relevant Lines: 24736

💛 - Coveralls

@reasonerjt reasonerjt requested review from ninjadq and removed request for ninjadq May 10, 2019 06:07
Copy link
Member

@ninjadq ninjadq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ywk253100 ywk253100 merged commit 64cacc9 into goharbor:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

harbor 1.7.4 aliyun oss chartmuseum 500
5 participants