Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue: https://github.com/goharbor/harbor/issues/7288 #7827

Merged
merged 1 commit into from
May 16, 2019
Merged

Fix issue: https://github.com/goharbor/harbor/issues/7288 #7827

merged 1 commit into from
May 16, 2019

Conversation

ninjadq
Copy link
Member

@ninjadq ninjadq commented May 16, 2019

Signed-off-by: liqiang-fit2cloud [email protected]

@liqiang-fit2cloud @ninjadq
Fix issue: goharbor#7288
501c15c 
Signed-off-by: liqiang-fit2cloud <[email protected]>
@ninjadq ninjadq requested review from wy65701436 and ywk253100 May 16, 2019 10:27
wy65701436
wy65701436 approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 64.506%
Files with Coverage Reduction New Missed Lines %
src/core/api/repository.go 3 43.62%
Totals Coverage Status
Change from base Build 12907: -0.01%
Covered Lines: 15995
Relevant Lines: 24796
💛 - Coveralls

@wy65701436 wy65701436 merged commit 25bb24c into goharbor:release-1.8.0 May 16, 2019
@ninjadq ninjadq deleted the cherry-pick-180-fix-ali-oss-storage-issue branch September 24, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@ywk253100 ywk253100 ywk253100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ninjadq @coveralls @wy65701436 @ywk253100 @liqiang-fit2cloud