Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the mount target of gcs.key file(1.8.1) #8057

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Change the mount target of gcs.key file(1.8.1) #8057

merged 1 commit into from
Jun 17, 2019

Conversation

stonezdj
Copy link
Contributor

Fix bug8055
Signed-off-by: stonezdj [email protected]

@stonezdj stonezdj changed the title Change the mount target of gcs.key file Change the mount target of gcs.key file(181) Jun 16, 2019
@stonezdj stonezdj changed the title Change the mount target of gcs.key file(181) Change the mount target of gcs.key file(1.8.1) Jun 16, 2019
wy65701436
wy65701436 approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13163

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 64.646%
Totals Coverage Status
Change from base Build 13157: 0.008%
Covered Lines: 16254
Relevant Lines: 25143
💛 - Coveralls

@stonezdj stonezdj merged commit 16b59c4 into goharbor:release-1.8.0 Jun 17, 2019
@stonezdj stonezdj deleted the bug8055_v180 branch October 21, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@ywk253100 ywk253100 ywk253100 approved these changes

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stonezdj @coveralls @wy65701436 @ywk253100