Fix creation of replications with dest_namespace_replace = 0 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `omitempty` tag from `DestNamespaceReplace` Signed-off-by: Dmitry G <[email protected]>
|
hi @dmitry-g, |
flbla
approved these changes
Jun 5, 2023
|
@dmitry-g congrats on merging your first PR here :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omitemptytag fromDestNamespaceReplaceWhen the value of
dest_namespace_replaceis set to0, Harbor actually creates a replication rule withdest_namespace_replace_countof-1(flatten all levels).It happens because
DestNamespaceReplacefield hasomitemptytag, which filters out the field when its value is set to0. Therefore Harbor falls back to its default value of-1(docs).All other, non-zero values work fine.
Also, I see that
omitemptytag was set some time ago by #282.Thank you