Skip to content

Commit

Permalink
publisher: Collect transition attributes as classes
Browse files Browse the repository at this point in the history
Fixes #7509
  • Loading branch information
bep committed Jul 23, 2020
1 parent 45c665d commit 00e00da
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion publisher/htmlElementsCollector.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ func isQuote(b byte) bool {
var (
htmlJsonFixer = strings.NewReplacer(", ", "\n")
jsonAttrRe = regexp.MustCompile(`'?(.*?)'?:.*`)
classAttrRe = regexp.MustCompile(`(?i)^class$|transition`)
)

func parseHTMLElement(elStr string) (el htmlElement) {
Expand All @@ -242,7 +243,7 @@ func parseHTMLElement(elStr string) (el htmlElement) {
// There should be only one, but one never knows...
el.IDs = append(el.IDs, a.Val)
default:
if strings.EqualFold(a.Key, "class") {
if classAttrRe.MatchString(a.Key) {
el.Classes = append(el.Classes, strings.Fields(a.Val)...)
} else {
key := strings.ToLower(a.Key)
Expand Down
1 change: 1 addition & 0 deletions publisher/htmlElementsCollector_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ func TestClassCollector(t *testing.T) {
}" class="block w-36 cursor-pointer pr-3 no-underline capitalize"></a>`, f("a", "block capitalize cursor-pointer no-underline pl-2 pl-3 pr-3 text-a text-b text-gray-600 w-36", "")},

{"Alpine transition 1", `<div x-transition:enter-start="opacity-0 transform mobile:-translate-x-8 sm:-translate-y-8">`, f("div", "mobile:-translate-x-8 opacity-0 sm:-translate-y-8 transform", "")},
{"Vue bind", `<div v-bind:class="{ active: isActive }"></div>`, f("div", "active", "")},
} {
c.Run(test.name, func(c *qt.C) {
Expand Down

0 comments on commit 00e00da

Please sign in to comment.