hugolib: Do not fall back to site title if not set in content file

See #5784
gohugoio · Mar 26, 2019 · 9bc6187 · 9bc6187
1 parent 10bb614
commit 9bc6187
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/hugolib/page__meta.go b/hugolib/page__meta.go
@@ -545,7 +545,7 @@ func (p *pageMeta) applyDefaultValues() error {
 		}
 	}
 
-	if p.title == "" {
+	if p.title == "" && p.f.IsZero() {
 		switch p.Kind() {
 		case page.KindHome:
 			p.title = p.s.Info.title

diff --git a/hugolib/page_test.go b/hugolib/page_test.go
@@ -1175,8 +1175,10 @@ func TestPageWithZeroFile(t *testing.T) {
 }
 
 func TestHomePageWithNoTitle(t *testing.T) {
-	b := newTestSitesBuilder(t).WithSimpleConfigFile().
-		WithTemplatesAdded("index.html", "Title|{{ with .Title }}{{ . }}{{ end }}|")
+	b := newTestSitesBuilder(t).WithConfigFile("toml", `
+title = "Site Title"
+`)
+	b.WithTemplatesAdded("index.html", "Title|{{ with .Title }}{{ . }}{{ end }}|")
 	b.WithContent("_index.md", `---
 description: "No title for you!"
 ---