Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in embedded templates social deprecation #11658

Closed
jmooring opened this issue Nov 1, 2023 · 1 comment · Fixed by #11660
Closed

Regression in embedded templates social deprecation #11658

jmooring opened this issue Nov 1, 2023 · 1 comment · Fixed by #11660
Assignees
@jmooring
Labels
Bug Feature: Embedded Template Outdated
Milestone
v0.120.3

Comments

@jmooring
Copy link
Member

jmooring commented Nov 1, 2023

The opengraph and twitter_cards template adjustments didn't consider this case:

[[params.social]]
key = 'val'

[[params.social]]
key = 'val'
@jmooring jmooring added the Bug label Nov 1, 2023
@jmooring jmooring self-assigned this Nov 1, 2023
This was referenced Nov 1, 2023
Closed
Closed
@bep bep added this to the v0.120.3 milestone Nov 1, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Nov 1, 2023
@jmooring
tpl/tplimpl: Fix deprecation logic in embedded templates
9700bd9 
Closes gohugoio#11658
jmooring added a commit to jmooring/hugo that referenced this issue Nov 1, 2023
@jmooring
tpl/tplimpl: Fix deprecation logic in embedded templates
c5edad6 
Closes gohugoio#11658
@jmooring jmooring mentioned this issue Nov 1, 2023
Merged
@bep bep closed this as completed in #11660 Nov 1, 2023
bep pushed a commit that referenced this issue Nov 1, 2023
@jmooring @bep
tpl/tplimpl: Fix deprecation logic in embedded templates
cb98e90 
Closes #11658
@SophiaAtkinson SophiaAtkinson mentioned this issue Nov 2, 2023
Closed
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Bug Feature: Embedded Template Outdated
Projects
None yet
Milestone
v0.120.3
Development

Successfully merging a pull request may close this issue.

tpl/tplimpl: Fix deprecation logic in embedded templates jmooring/hugo
2 participants
@jmooring @bep