Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache processed images by their source path #6269

Closed
bep opened this issue Aug 26, 2019 · 2 comments · Fixed by #6301
Closed

Cache processed images by their source path #6269

bep opened this issue Aug 26, 2019 · 2 comments · Fixed by #6301
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.58

Comments

@bep
Copy link
Member

bep commented Aug 26, 2019

No description provided.

@bep bep added this to the v0.58 milestone Aug 26, 2019
@bep bep self-assigned this Aug 26, 2019
@bep bep added the Bug label Sep 3, 2019
@bep
Copy link
Member Author

bep commented Sep 3, 2019

OK, I checked. We currently cache by their target path:

/bundle/sunset_hu59e56ffff1bc1d8d122b1403d34e039f_90587_200x200_resize_q75_box.jpg bundle/sunset.jpg
/nn/bundle/sunset_hu59e56ffff1bc1d8d122b1403d34e039f_90587_200x200_resize_q75_box.jpg bundle/sunset.jpg
/fr/bundle/sunset_hu59e56ffff1bc1d8d122b1403d34e039f_90587_200x200_resize_q75_box.jpg bundle/sunset.jpg

This works, but it means that we do unneeded image processing and wastes disk space in multilingual setups.

@bep bep changed the title Check image cache duplication for languages Cache processed images by their source path Sep 3, 2019
bep added a commit to bep/hugo that referenced this issue Sep 3, 2019
@bep
Cache processed images by their source path
c444777 
Fixes gohugoio#6269
@bep bep mentioned this issue Sep 3, 2019
Merged
bep added a commit to bep/hugo that referenced this issue Sep 3, 2019
@bep
Cache processed images by their source path
75da86a 
Fixes gohugoio#6269
bep added a commit to bep/hugo that referenced this issue Sep 3, 2019
@bep
Cache processed images by their source path
b875b4a 
Fixes gohugoio#6269
@bep bep closed this as completed in #6301 Sep 3, 2019
bep added a commit that referenced this issue Sep 3, 2019
@bep
Cache processed images by their source path
8624b9f 
Fixes #6269
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.58
Development

Successfully merging a pull request may close this issue.

Cache processed images by their source path bep/hugo
1 participant
@bep